Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1852300 use bptp-built tag for nodejs tests #983

Merged
merged 2 commits into from
Dec 10, 2024
Merged

SNOW-1852300 use bptp-built tag for nodejs tests #983

merged 2 commits into from
Dec 10, 2024

Conversation

sfc-gh-akolodziejczyk
Copy link
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented Dec 10, 2024 •
edited by jira bot
Loading

Description

SNOW-1852300

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the types in index.d.ts file (if necessary)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review December 10, 2024 14:52
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner December 10, 2024 14:52
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk changed the title SNOW-1852300 trigger build SNOW-1852300 use bptp-built tag for nodejs tests Dec 10, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (85a6a39) to head (60a5758).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #983   +/-   ##
=======================================
  Coverage   88.86%   88.86%           
=======================================
  Files          72       72           
  Lines        6944     6944           
=======================================
  Hits         6171     6171           
  Misses        773      773

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk merged commit d7eed90 into master Dec 10, 2024
59 checks passed
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk deleted the SNOW-1852300 branch December 10, 2024 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pmotacki sfc-gh-pmotacki sfc-gh-pmotacki approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-akolodziejczyk @sfc-gh-pbulawa @sfc-gh-pmotacki